From 89c00fc772effbbae00b08b4f6332107729d4389 Mon Sep 17 00:00:00 2001
From: devdatt <shreebhattji@urmic.org>
Date: Tue, 23 Dec 2025 14:46:45 +0530
Subject: [PATCH] foreach

---
 encoder/network.php | 31 ++++++++-----------------------
 1 file changed, 8 insertions(+), 23 deletions(-)

diff --git a/encoder/network.php b/encoder/network.php
index b910c9e..5b2d581 100755
--- a/encoder/network.php
+++ b/encoder/network.php
@@ -134,29 +134,13 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
                 'version' => 2,
                 'renderer' => 'networkd',
                 'ethernets' => [],
-                'vlans' => new stdClass()
+                'vlans' => []   // MUST be array while building
             ]
         ];
 
-        /* ---------- PRIMARY ---------- */
-        if (
-            $data['primary']['mode'] !== 'disabled' ||
-            $data['primary']['modev6'] !== 'disabled'
-        ) {
-            $netplan['network']['ethernets'][$iface] =
-                build_interface($data['primary'], 'primary');
-
-            /* ---------- SECONDARY ---------- */
-        } elseif (
-            $data['secondary']['mode'] !== 'disabled' ||
-            $data['secondary']['modev6'] !== 'disabled'
-        ) {
-            $netplan['network']['ethernets'][$iface] =
-                build_interface($data['secondary'], 'secondary');
-        }
-
         foreach (['primary', 'secondary'] as $type) {
 
+            /* Skip disabled blocks */
             if (
                 $data[$type]['mode'] === 'disabled' &&
                 $data[$type]['modev6'] === 'disabled'
@@ -166,15 +150,16 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
 
             $vlan = trim($data[$type]["network_{$type}_vlan"] ?? '');
 
-            if ($vlan === '') {
-                $netplan['network']['ethernets'][$iface] =
-                    build_interface($data[$type], $type);
-            } else {
+            /* Base NIC must exist if any VLAN is used */
+            if ($vlan !== '') {
                 $netplan['network']['ethernets'][$iface] = new stdClass();
 
                 $netplan['network']['vlans']["{$iface}.{$vlan}"] =
                     array_merge(
-                        ['id' => (int)$vlan, 'link' => $iface],
+                        [
+                            'id'   => (int)$vlan,
+                            'link' => $iface
+                        ],
                         build_interface($data[$type], $type)
                     );
             }